Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark new security(safety) issues for ignore #2916

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

KSchopmeyer
Copy link
Collaborator

@KSchopmeyer KSchopmeyer commented Sep 2, 2022

New security issues on dparse, ipwidgets, nbconvert. Marked all to be
ignored for now.

I just marked them for ignore for the moment since they are all packages
that are part of test environment and not pywbem pip package. I took this as the fastest approach to getting
CI running with number of outstanding Open PRs

===================
I tried to use dparse rather than just ignore it. It would appear that this is not possible with
python 2.7 however. I changed the limits in dev-requirements and minimum-constraints for dparse dparse I enabled min version 0.5.2 for all but python 2.7 and put entry into ignore list (in the Makefile) for python 2.7.
However, that is not working correctly as of Friday afternoon.

For example fails with python 3.10, ubuntu, minimum test but results show that it is installing dparse 0.5.2 but issueing
the security message about dparse 0.4.1. Since I am trying to fix issue for Walker, I had to stop Frday evening for
now.

NOTE: That work not committed.

=====================

| REPORT                                                                       |
| checked 237 packages, using default DB                                       |
+============================+===========+==========================+==========+
| package                    | installed | affected                 | ID       |
+============================+===========+==========================+==========+
| lxml                       | 4.6.2     | <4.9.1                   | 50748    |
+==============================================================================+
| Lxml 4.9.1 include a fix for CVE-2022-2309: NULL Pointer Dereference allows  |
| attackers to cause a denial of service (or application crash). This only     |
| applies when lxml is used together with libxml2 2.9.10 through 2.9.14.       |
| Libxml2 2.9.9 and earlier versions are not affected. It allows triggering    |
| crashes through forged input data, given a vulnerable code sequence in the   |
| application. The vulnerability is caused by the iterwalk function (also used |
| by the canonicalize function). Such code shouldn't be in wide-spread use,    |
| given that parsing + iterwalk would usually be replaced with the more        |
| efficient iterparse function. However, an XML converter that serializes to   |
| C14N would also be vulnerable, for example, and there are legitimate use     |
| cases for this code sequence. If untrusted input is received (also remotely) |
| and processed via iterwalk function, a crash can be triggered.               |
+==============================================================================+
| lxml                       | 4.6.2     | <4.9.1                   | 50748    |
+==============================================================================+
| Lxml 4.9.1 include a fix for CVE-2022-2309: NULL Pointer Dereference allows  |
| attackers to cause a denial of service (or application crash). This only     |
| applies when lxml is used together with libxml2 2.9.10 through 2.9.14.       |
| Libxml2 2.9.9 and earlier versions are not affected. It allows triggering    |
| crashes through forged input data, given a vulnerable code sequence in the   |
| application. The vulnerability is caused by the iterwalk function (also used |
| by the canonicalize function). Such code shouldn't be in wide-spread use,    |
| given that parsing + iterwalk would usually be replaced with the more        |
| efficient iterparse function. However, an XML converter that serializes to   |
| C14N would also be vulnerable, for example, and there are legitimate use     |
| cases for this code sequence. If untrusted input is received (also remotely) |
| and processed via iterwalk function, a crash can be triggered.               |
+==============================================================================+
| lxml                       | 4.6.4     | <4.9.1                   | 50748    |
+==============================================================================+
| Lxml 4.9.1 include a fix for CVE-2022-2309: NULL Pointer Dereference allows  |
| attackers to cause a denial of service (or application crash). This only     |
| applies when lxml is used together with libxml2 2.9.10 through 2.9.14.       |
| Libxml2 2.9.9 and earlier versions are not affected. It allows triggering    |
| crashes through forged input data, given a vulnerable code sequence in the   |
| application. The vulnerability is caused by the iterwalk function (also used |
| by the canonicalize function). Such code shouldn't be in wide-spread use,    |
| given that parsing + iterwalk would usually be replaced with the more        |
| efficient iterparse function. However, an XML converter that serializes to   |
| C14N would also be vulnerable, for example, and there are legitimate use     |
| cases for this code sequence. If untrusted input is received (also remotely) |
| and processed via iterwalk function, a crash can be triggered.               |
+==============================================================================+
| dparse                     | 0.4.1     | <0.5.2                   | 50571    |
+==============================================================================+
| Dparse 0.5.2 fixes a possible ReDoS vulnerability. https://github.com/pyupio |
| /dparse/commit/8c990170bbd6c0cf212f1151e9025486556062d5                      |
+==============================================================================+
| dparse                     | 0.5.1     | <0.5.2                   | 50571    |
+==============================================================================+
| Dparse 0.5.2 fixes a possible ReDoS vulnerability. https://github.com/pyupio |
| /dparse/commit/8c990170bbd6c0cf212f1151e9025486556062d5                      |
+==============================================================================+
| ipywidgets                 | 5.2.2     | <8.0.0                   | 50664    |
+==============================================================================+
| Ipywidgets 8.0.0 sanitizes descriptions by default.                          |
| https://github.com/jupyter-widgets/ipywidgets/pull/2785                      |
+==============================================================================+
| ipywidgets                 | 5.2.2     | <8.0.0rc2                | 50463    |
+==============================================================================+
| Ipywidgets 8.0.0rc2 makes descriptions plaintext by default for security.    |
| https://github.com/jupyter-widgets/ipywidgets/pull/2785                      |
+==============================================================================+
| nbconvert                  | 5.0.0     | <6.5.1                   | 50792    |
+==============================================================================+
| Nbconvert 6.5.1 includes a fix for CVE-2021-32862: Multiple                  |
| sanitization/validation issues.                                              |
| https://github.com/jupyter/nbconvert/security/advisories/GHSA-9jmq-rx5f-8jwq |
+==============================================================================+
make: *** [Makefile:815: safety_py3.5.done] Error 255

@KSchopmeyer KSchopmeyer self-assigned this Sep 2, 2022
@KSchopmeyer KSchopmeyer changed the title Mark new security issues for ignore Mark new security(safety) issues for ignore Sep 2, 2022
New security issues on dparse, ipwidgets, nbconvert.  Marked all to be
ignored for now.

I just marked them for ignore for the moment since they are all packages
that are part of test environment and not pywbem pip package.
@KSchopmeyer KSchopmeyer added the rollback needed Roll back/foward is needed label Sep 2, 2022
@coveralls
Copy link

coveralls commented Sep 2, 2022

Coverage Status

Coverage remained the same at 92.292% when pulling 89f64ed on ks/sept-1-new-security-issues into f2c8b87 on master.

@andy-maier andy-maier merged commit 054f998 into master Sep 19, 2022
@andy-maier andy-maier deleted the ks/sept-1-new-security-issues branch September 19, 2022 20:03
@andy-maier andy-maier added rollback done Roll back/forward has been done and removed rollback needed Roll back/foward is needed labels Sep 19, 2022
@andy-maier andy-maier added this to the 1.5.0 milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority rollback done Roll back/forward has been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants