-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow installing specific Mesa3D release #22
Conversation
Pinging @larsoner @tlambert03 and @banesullivan for feedback and review! Thanks in advance =) |
* feat: fix * feat: fix * final fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I feared that hardcoding values for the systemwidedeploy.cmd
file might backfire but this file hasn't changed in two years, see https://github.com/pal1000/mesa-dist-win/blob/master/bin/systemwidedeploy.cmd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny suggestion which I'll apply and merge, this is great, thanks!
Awesome, thanks a lot @larsoner! =) Would it be possible to get a release with this change? |
Looks like |
Hmm... for some reason the env var is giving some problems on test (windows-2022) but not on test (windows-latest)... |
Still comes up blank for the version 😞 |
Yeah saw that... the thing is that it only happens with windows-2022 😮 |
Maybe instead
? |
jq is not available in some Windows Bash terminals 😢 |
I added some extra logging to make it easy for users to debug as well |
It ended up working here: https://github.com/pyvista/setup-headless-display-action/actions/runs/12121505042/job/33793270066 Let's let it re-run again. Might have been some transient issue |
Looks like retrieving the version can just be a bit flaky or fail sometimes as 891324c failed but worked once I restarted it. Not sure if there's a good way around that. |
@RobPasMue given 1) |
Thanks @RobPasMue ! |
Released as v3.1 and updated v3 to point to it |
Sounds good! Thanks @larsoner for all your support! |
A user might want to install a specific version of Mesa3D on their self-hosted runner or GitHub runner. This change would allow them to do so. Also, it will allow the action, by default, to always pull the latest Mesa3D version available rather than a hard-coded one. See commit b2a733a
Furthermore - we should use the installers that are shipped by Mesa3D in order to avoid DLL incompatibility issues. See commits d6dd86a and adb571e
Added documentation on how to use the input, and modified the action and bash scripts as well. Let me know if there's anything else I can contribute with!