Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies for test extra by downgrading to nbdime<4 #23

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 22, 2023

Problem

Both PRs submitted by Dependabot revealed that something went south.

Analysis

We discovered that it was about the nbdime package, apparently breaking a little detail with its 4.x release. We submitted a corresponding report to the upstream repository.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e5878a) 74.37% compared to head (378e301) 74.37%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   74.37%   74.37%           
=======================================
  Files          17       17           
  Lines         562      562           
=======================================
  Hits          418      418           
  Misses        144      144           
Flag Coverage Δ
main 74.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl marked this pull request as ready for review November 22, 2023 16:33
@amotl amotl requested review from matriv and WalBeh November 22, 2023 16:33
@amotl amotl merged commit 240ba98 into main Nov 22, 2023
4 checks passed
@amotl amotl deleted the downgrade-nbdime branch November 22, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant