Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding scale and offset values #177

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

gerritholl
Copy link
Contributor

Add an option to override the automatically calculated scale and offset tags.

  • Partially closes ninjogeotiff writer should write gradient for P mode images satpy#2869
  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)
  • Passes git diff origin/master **/*py | flake8 --diff (remove if you did not edit any Python files)
  • Fully documented (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

Allow overriding the automatically determined values of scale and
offset with values passed by the user.
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (8b71319) to head (f0d8d4c).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   91.53%   91.54%   +0.01%     
==========================================
  Files          11       11              
  Lines        4062     4071       +9     
==========================================
+ Hits         3718     3727       +9     
  Misses        344      344              
Flag Coverage Δ
unittests 91.54% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 91.796% (+0.02%) from 91.777%
when pulling f0d8d4c on gerritholl:feature-override-scale-offset
into c665c4d on pytroll:main.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a pretty clean solution to the problem, but I was wondering if the simpler solution of turning them off would work for your NinJo-specific problem?

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit b0458c9 into pytroll:main Aug 15, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants