Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build against numpy 2.0rc1 #168

Merged
merged 7 commits into from
Apr 15, 2024
Merged

Build against numpy 2.0rc1 #168

merged 7 commits into from
Apr 15, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Apr 12, 2024

  • Closes #xxxx (remove if there is no corresponding issue, which should only be the case for minor changes)
  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)
  • Passes git diff origin/master **/*py | flake8 --diff (remove if you did not edit any Python files)
  • Fully documented (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (2d126fc) to head (c77b830).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   91.63%   91.84%   +0.20%     
==========================================
  Files          12       12              
  Lines        4043     4033      -10     
==========================================
- Hits         3705     3704       -1     
+ Misses        338      329       -9     
Flag Coverage Δ
unittests 91.84% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Apr 12, 2024

Coverage Status

coverage: 91.867%. remained the same
when pulling c77b830 on djhoese:build-np2rc1
into b137ced on pytroll:main.

@djhoese
Copy link
Member Author

djhoese commented Apr 15, 2024

Ok so the remaining unstable failures all seem to be caused by xarray incompatibility with numpy 2. See pydata/xarray#8402. With the changes mentioned in that PR things seem to pass except for another numpy import in xarray causing a deprecation warning. So theoretically fixes in xarray should fix this just fine. I'm going to merge and release this as is.

@djhoese djhoese merged commit 1a15876 into pytroll:main Apr 15, 2024
25 of 26 checks passed
@djhoese djhoese deleted the build-np2rc1 branch April 15, 2024 19:04
@djhoese djhoese added bug and removed enhancement labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants