-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build against numpy 2.0rc1 #168
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
+ Coverage 91.63% 91.84% +0.20%
==========================================
Files 12 12
Lines 4043 4033 -10
==========================================
- Hits 3705 3704 -1
+ Misses 338 329 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ok so the remaining unstable failures all seem to be caused by xarray incompatibility with numpy 2. See pydata/xarray#8402. With the changes mentioned in that PR things seem to pass except for another numpy import in xarray causing a deprecation warning. So theoretically fixes in xarray should fix this just fine. I'm going to merge and release this as is. |
git diff origin/master **/*py | flake8 --diff
(remove if you did not edit any Python files)