Cleanup styling in ami_l1b reader more
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Jul 19, 2024 in 33s
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.17 (9.32 -> 9.14)
- Declining Code Health: 1 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication test_ami_l1b.py
Annotations
Check notice on line 121 in satpy/readers/ami_l1b.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Excess Number of Function Arguments
AMIL1bNetCDF.__init__ increases from 6 to 7 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check warning on line 189 in satpy/tests/reader_tests/test_ami_l1b.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Code Duplication
introduced similar code in: _fake_ir_attrs,_fake_vis_attrs. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Loading