Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing warnings import to geotiff writer #750

Merged
merged 1 commit into from
May 3, 2019

Conversation

jackieleng
Copy link
Contributor

This PR adds a missing warnings import. Otherwise when rasterio isn't available you will get: UnboundLocalError: local variable 'warnings' referenced before assignment

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂ Thanks.

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #750 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
- Coverage   80.69%   80.68%   -0.01%     
==========================================
  Files         149      149              
  Lines       21649    21650       +1     
==========================================
  Hits        17469    17469              
- Misses       4180     4181       +1
Impacted Files Coverage Δ
satpy/writers/geotiff.py 41.66% <0%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f21d20...4cf3232. Read the comment docs.

@djhoese djhoese changed the title Add missing warnings import Add missing warnings import to geotiff writer May 3, 2019
@djhoese djhoese merged commit d0ff651 into pytroll:master May 3, 2019
@jackieleng jackieleng deleted the warnings-import branch May 3, 2019 19:13
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 80.688% when pulling 4cf3232 on jackieleng:warnings-import into 1f21d20 on pytroll:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants