Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hurricane florence demo download to only include M1 files #715

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Apr 10, 2019

The ABI files are set up strangely on GCP. Both M1 and M2 files go in a "RadM" files. I was accidentally downloading both when I only needed one of them (M1). There isn't really a way to test this without actually downloading the information from google.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

@djhoese djhoese added the bug label Apr 10, 2019
@djhoese djhoese self-assigned this Apr 10, 2019
@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #715 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
+ Coverage   79.99%   79.99%   +<.01%     
==========================================
  Files         147      147              
  Lines       21471    21471              
==========================================
+ Hits        17175    17176       +1     
+ Misses       4296     4295       -1
Impacted Files Coverage Δ
satpy/demo/__init__.py 95.12% <ø> (ø) ⬆️
satpy/scene.py 89.89% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fa3f3d...e665dfa. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 79.996% when pulling e665dfa on djhoese:bugfix-demo-meso1-only into 9fa3f3d on pytroll:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 79.996% when pulling e665dfa on djhoese:bugfix-demo-meso1-only into 9fa3f3d on pytroll:master.

@djhoese djhoese merged commit 35fbc9f into pytroll:master Apr 10, 2019
@djhoese djhoese deleted the bugfix-demo-meso1-only branch April 10, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants