Fix confusing error in abi_l1b reader when file fails to open #615
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there are cases where the ABI L1B reader can't open a file and it never creates
self.nc
. In these cases the__del__
method was trying to accessself.nc.close()
and failing with anAttributeError
. This AttributeError was getting through to the user and making the overall issue with their use of the reader confusing. This PR catches the AttributeError and stops it from being shown to the user. The rest of the reader should still properly report what went wrong with opening the file (not found, etc).git diff origin/master -- "*py" | flake8 --diff