-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'reduce_data' keyword argument to disable cropping before resampling #582
Conversation
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
=========================================
+ Coverage 77.57% 77.67% +0.1%
=========================================
Files 136 136
Lines 19194 19209 +15
=========================================
+ Hits 14889 14921 +32
+ Misses 4305 4288 -17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explicitly add the keyword argument to the resample
method and document it in the docstring. Otherwise this looks good to me.
The test failures in |
I merged #595 which should fix the errors you were receiving for now. I restarted the tests and hopefully it picks up on the changes in master. Otherwise I'll merge master in to your branch for this. |
Fix resample reduce_data bug introduced in #582
This PR adds a way to disable data reduction before resampling. This is a work-around for #383 that might be useful even after fixing pyresample.
git diff origin/master -- "*py" | flake8 --diff
Usage when calling resampling:
The default is to apply data reduction.
Not sure where to document this, as resampling documentation is coming direct from resample.py docstrings, and this fix happens in scene.py. Suggestions?