Fix EWA resampling for new versions of pyresample #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current pyresample master branch returns dask arrays from get_lonlats if they were already dask arrays underneath. Previously this method would return whatever was passed to SwathDefinition.
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
=========================================
Coverage ? 75.41%
=========================================
Files ? 136
Lines ? 18777
Branches ? 0
=========================================
Hits ? 14160
Misses ? 4617
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current pyresample master branch returns dask arrays from
get_lonlats if they were already dask arrays underneath. Previously
this method would return whatever was passed to SwathDefinition.
This was caught by my local tests where I'm using pyresample master branch. This would have been caught by tests in the future once the new pyresample is released, so no tests were added. I'm just fixing this preemptively.
git diff origin/master -- "*py" | flake8 --diff