Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DOI role and reference to Zinke DNB method #501

Merged
merged 3 commits into from
Nov 12, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Nov 12, 2018

This is the ground work for #500, but I wouldn't say it closes it. I would say this is fully documented, but the role is really not fully documented. It doesn't even exist outside of scipy and the other projects that have copied it from a gist someone made a while ago. The module is copied in to the sphinx doc source. I was able to use it nicely on the NCC DNB compositor for Stephan Zinke's paper.

  • Fully documented

@djhoese djhoese added this to the v0.10 milestone Nov 12, 2018
@djhoese djhoese self-assigned this Nov 12, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 74.067% when pulling 1f7d9bf on djhoese:doc-references into f842a46 on pytroll:master.

@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #501 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #501   +/-   ##
=======================================
  Coverage   74.08%   74.08%           
=======================================
  Files         137      137           
  Lines       18220    18220           
=======================================
  Hits        13499    13499           
  Misses       4721     4721
Impacted Files Coverage Δ
satpy/writers/__init__.py 76.19% <ø> (ø) ⬆️
satpy/composites/viirs.py 84.09% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f842a46...1f7d9bf. Read the comment docs.

@djhoese djhoese merged commit 32f2afa into pytroll:master Nov 12, 2018
@djhoese djhoese deleted the doc-references branch November 12, 2018 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants