Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug introduced for SLSTR cloud flags when naming convention changed #482

Merged

Conversation

egede
Copy link
Contributor

@egede egede commented Oct 31, 2018

In #458 the name of the longitude and latitude elements in the YAML file was updated to have the sufixes for the stripes and views. This was not migrated to the cloud masks that are subsequently using this. No change in Python code.

  • Tests added
  • Tests passed

@egede
Copy link
Contributor Author

egede commented Oct 31, 2018

Thanks to @dr1315 and @barnabysandeford for identifying issue.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.156% when pulling cb98a51 on egede:SLSTR-update-metadata-lat-and-longitude into 7c8cdc4 on pytroll:master.

@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #482 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #482   +/-   ##
=======================================
  Coverage   74.15%   74.15%           
=======================================
  Files         136      136           
  Lines       18070    18070           
=======================================
  Hits        13400    13400           
  Misses       4670     4670

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c8cdc4...cb98a51. Read the comment docs.

@mraspaud mraspaud changed the title Fix bug introduced for cloud flags when naming convention changed Fix bug introduced for SLSTR cloud flags when naming convention changed Oct 31, 2018
@mraspaud
Copy link
Member

Thanks for spotting and fixing this!

@mraspaud mraspaud merged commit 7f2d2d9 into pytroll:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants