Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of missing file requirements in readers #452

Merged
merged 18 commits into from
Dec 19, 2018
Merged

Improve handling of missing file requirements in readers #452

merged 18 commits into from
Dec 19, 2018

Commits on Dec 19, 2018

  1. Improve handling of missing requirements

    @sfinkens @djhoese
    sfinkens authored and djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    d510d52 View commit details
    Browse the repository at this point in the history

  2. Add proper RuntimeError message 

    When the exception is catched, redirect the message into the
warning.

To improve readability, make the warning statement fit in one line
and don't exclude the source line from the message.
    @sfinkens @djhoese
    sfinkens authored and djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    c5419b9 View commit details
    Browse the repository at this point in the history

  3. Remove premature check

    @sfinkens @djhoese
    sfinkens authored and djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    ea19bdf View commit details
    Browse the repository at this point in the history

  4. Check for empty Dataset IDs in Scene

    @sfinkens @djhoese
    sfinkens authored and djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    378f87b View commit details
    Browse the repository at this point in the history

  5. Fix tests

    @sfinkens @djhoese
    sfinkens authored and djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    ff14ece View commit details
    Browse the repository at this point in the history

  6. Use string representation of exceptions 

    BaseException.message was removed in python3
    @sfinkens @djhoese
    sfinkens authored and djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    5f83d79 View commit details
    Browse the repository at this point in the history

  7. Check any possible readers

    @sfinkens @djhoese
    sfinkens authored and djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    fab8676 View commit details
    Browse the repository at this point in the history

  8. Revert "Check any possible readers" 

    This reverts commit d185699.
    @sfinkens @djhoese
    sfinkens authored and djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    e74df14 View commit details
    Browse the repository at this point in the history

  9. Revert "Remove unused variables" 

    This reverts commit 1f5cce9.
    @sfinkens @djhoese
    sfinkens authored and djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    8712cb9 View commit details
    Browse the repository at this point in the history

  10. Revert "Fix tests" 

    This reverts commit 177593d.
    @sfinkens @djhoese
    sfinkens authored and djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    abcd470 View commit details
    Browse the repository at this point in the history

  11. Revert "Check for empty Dataset IDs in Scene" 

    This reverts commit 5a46baf.
    @sfinkens @djhoese
    sfinkens authored and djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    2aca029 View commit details
    Browse the repository at this point in the history

  12. Check available dataset IDs in load_readers 

    If valid files were given but no dataset could be loaded, raise
an exception.
    @sfinkens @djhoese
    sfinkens authored and djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    23f20cb View commit details
    Browse the repository at this point in the history

  13. Clarify user warnings 

    1) There is no handler for reading a requirement
2) There is a handler but it doesn't match the current file
    @sfinkens @djhoese
    sfinkens authored and djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    2949aec View commit details
    Browse the repository at this point in the history

  14. Fix stickler issue

    @sfinkens @djhoese
    sfinkens authored and djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    8a7c9b5 View commit details
    Browse the repository at this point in the history

  15. Fix typo in docstring

    @sfinkens @djhoese
    sfinkens authored and djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    8ae6e8b View commit details
    Browse the repository at this point in the history

  16. Change reader loading to allow for some reader loading to fail

    @djhoese
    djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    9b9e725 View commit details
    Browse the repository at this point in the history

  17. Fix stickler style issues

    @djhoese
    djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    34d2aeb View commit details
    Browse the repository at this point in the history

  18. Fix hrit_msg usage in reader tests 

    The hrit_msg reader is now called seviri_l1b_hrit
    @djhoese
    djhoese committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    a72d4e5 View commit details
    Browse the repository at this point in the history