Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nc_nwcsaf_msg reader's handling of projection units #446

Merged
merged 3 commits into from
Oct 11, 2018

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Oct 8, 2018

The reader for NWC SAF GEO was based on NetCDF files with Earth shape (a, b) and satellite altitude h in kilometers, but the area extents in meters. Apparently in some (or most?) cases the projection in proj4_string has these defined properly in meters.

This PR adds a check in which of these proj4_string is in the file.

  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 73.25% when pulling 0d43839 on bugfix-nc_nwcsaf_coordinates into 75e8cb8 on master.

@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #446 into master will increase coverage by 0.17%.
The diff coverage is 88.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   73.07%   73.25%   +0.17%     
==========================================
  Files         134      135       +1     
  Lines       17662    17716      +54     
==========================================
+ Hits        12907    12977      +70     
+ Misses       4755     4739      -16
Impacted Files Coverage Δ
satpy/tests/reader_tests/__init__.py 97.36% <100%> (+0.07%) ⬆️
satpy/readers/nc_nwcsaf.py 36.18% <81.25%> (+19.16%) ⬆️
satpy/tests/reader_tests/test_nc_nwcsaf.py 90.47% <90.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e8cb8...0d43839. Read the comment docs.

@djhoese djhoese merged commit 03b5044 into master Oct 11, 2018
@djhoese djhoese deleted the bugfix-nc_nwcsaf_coordinates branch October 11, 2018 16:44
@djhoese djhoese added the bug label Oct 11, 2018
@djhoese djhoese changed the title Bugfix nc_nwcsaf_msg reader projection units handling Fix nc_nwcsaf_msg reader's handling of projection units Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants