Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long_description to setup.py #443

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Oct 5, 2018

See related issue for more info.

@djhoese djhoese self-assigned this Oct 5, 2018
@djhoese djhoese requested a review from mraspaud October 5, 2018 13:52
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not using BASE_PATH ?

@djhoese
Copy link
Member Author

djhoese commented Oct 5, 2018

PyCharm said we weren't and the code that was using it was from 2010. Not sure why PyCharm and other linters didn't find it sooner.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.078% when pulling f59cd18 on djhoese:bugfix-long-description into f51790b on pytroll:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.078% when pulling f59cd18 on djhoese:bugfix-long-description into f51790b on pytroll:master.

@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #443 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #443   +/-   ##
=======================================
  Coverage   73.07%   73.07%           
=======================================
  Files         134      134           
  Lines       17662    17662           
=======================================
  Hits        12907    12907           
  Misses       4755     4755

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f51790b...f59cd18. Read the comment docs.

@djhoese djhoese merged commit 2773d36 into pytroll:master Oct 5, 2018
@djhoese djhoese deleted the bugfix-long-description branch October 5, 2018 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants