Remove co2_corrected modifier for METimage 3.74 µm #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the co2_corrected modifier for the METimage 3.74 µm channel. The CO2 correction was developed specifically for the SEVIRI 3.9 µm channel and should not be applied to channel where the CO₂ impact is different.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2958 +/- ##
==========================================
- Coverage 96.09% 96.08% -0.02%
==========================================
Files 377 377
Lines 55125 55125
==========================================
- Hits 52975 52967 -8
- Misses 2150 2158 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11590074818Details
💛 - Coveralls |
|
Yeah! I am very much in favour of that! |
adybbroe
approved these changes
Nov 8, 2024
|
Here we see how SEVIRI is really different from the "rest" concerning this channel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the co2_corrected modifier for the METimage 3.74 µm channel. The CO₂ correction was developed specifically for the SEVIRI 3.9 µm channel and should not be applied to channels where the CO₂ impact is different / (mostly) absent.