Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AWIPS tiled writer handling of odd units in VIIRS EDR products #2876

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Aug 6, 2024

@kathys and @cfdierking noticed that some VIIRS EDR products have the units "Meter" which is not CF compliant nor AWIPS compliant. This PR adds a work around to the AWIPS tiled writer to rewrite "Meter" as "meters. I'm making this a "draft PR" for now as I might add more unit conversions if Kathy or Carl find others. This is a small enough fix that is more about AWIPS and input file metadata than the writer operating properly so I won't be adding a test.

  • Closes #xxxx
  • Tests added
  • Fully documented

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (f3a2343) to head (b25107d).
Report is 182 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2876   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files         368      368           
  Lines       53973    53973           
=======================================
  Hits        51801    51801           
  Misses       2172     2172           
Flag Coverage Δ
behaviourtests 4.02% <ø> (ø)
unittests 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10269680993

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.073%

Totals Coverage Status
Change from base Build 10259110188: 0.0%
Covered Lines: 52030
Relevant Lines: 54157

💛 - Coveralls

@djhoese djhoese marked this pull request as ready for review August 8, 2024 14:08
@djhoese djhoese merged commit d214676 into pytroll:main Aug 8, 2024
17 of 18 checks passed
@djhoese djhoese deleted the bugfix-awips-units branch August 8, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants