Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thresholds for FCI geo_color low-level cloud layer #2862

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

strandgren
Copy link
Collaborator

@strandgren strandgren commented Jul 26, 2024

This PR updates the thresholds used for the low-level cloud detection used in the FCI geo_color recipe. This update is needed to properly capture low level clouds, especially over land, following the evolution and improvement in FCI IR calibration during MTG-I commissioning since this recipe was initially added.

The thresholds over water surfaces are now in line with those used for ABI and AHI, whereas the lower threshold over land surface types is slightly higher. This is done in order to mitigate the false alarms over desert areas which are inevitable with the current geo_color implementation given the difference in surface emissivity between the ir_38 and ir_105 channels. For FCI, this is a bigger challenge given the presence of the Sahara desert.

The current set of thresholds are proposed by myself and @ameraner as they seem to provide a rather good tradeoff. But mitigating the false alarms over Sahara, naturally comes with the expense of slightly lower sensitivity of actual low clouds over other land surface types. So I'm happy to revise if others prefer to use the same threshold as for ABI and AHI.

Below a set of images comparing different thresholds of a couple of scenes. Note in the full disk images, that all arid surface types or surface types with significantly difference surface emissivity (also over southern Africa and South America) have a blue glow when using the same thresholds as ABI and AHI.

image

The full resolution images can be seen here:

And an animation (different date) with the proposed thresholds (this PR) can be seen here.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (5e19113) to head (075405c).
Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2862      +/-   ##
==========================================
- Coverage   95.98%   95.96%   -0.03%     
==========================================
  Files         368      368              
  Lines       53852    53892      +40     
==========================================
+ Hits        51692    51718      +26     
- Misses       2160     2174      +14     
Flag Coverage Δ
behaviourtests 4.03% <ø> (-0.01%) ⬇️
unittests 96.06% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10109046433

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.065%

Totals Coverage Status
Change from base Build 10108565083: 0.0%
Covered Lines: 51947
Relevant Lines: 54075

💛 - Coveralls

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we're not far from having a pure-satpy cloudtype product now ;)

@mraspaud mraspaud merged commit bf0d9cd into pytroll:main Jul 29, 2024
16 of 18 checks passed
@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:compositors enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants