Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure lazyness of the olci nc reader #2819

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

mraspaud
Copy link
Member

This PR fixes the olci nc reader so that the netcdf4 files for geolocaltion are not opened until necessary.

I really see this as a refactoring, so I didn't add any test, but I could if the reviewer thinks it's needed.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@mraspaud mraspaud added the bug label Jun 13, 2024
@mraspaud mraspaud requested a review from djhoese June 13, 2024 12:09
@mraspaud mraspaud self-assigned this Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (83678ac) to head (deeafbe).
Report is 397 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2819      +/-   ##
==========================================
- Coverage   95.95%   95.94%   -0.02%     
==========================================
  Files         368      366       -2     
  Lines       53692    53508     -184     
==========================================
- Hits        51518    51336     -182     
+ Misses       2174     2172       -2     
Flag Coverage Δ
behaviourtests 4.04% <0.00%> (+0.01%) ⬆️
unittests 96.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jun 13, 2024

Pull Request Test Coverage Report for Build 9499345069

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.04%

Totals Coverage Status
Change from base Build 9497248893: 0.0%
Covered Lines: 51565
Relevant Lines: 53691

💛 - Coveralls

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a good place for it and actual data are accessed in the tests, it'd be nice to have a check with satpy.tests.utils.CustomScheduler that there are no uninted computes. Otherwise LGTM.

@mraspaud
Copy link
Member Author

No actual data is read i think, but good point for the future!

@mraspaud mraspaud merged commit df4a1ba into pytroll:main Jun 24, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants