Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uniqueness of hdf5-based dask arrays #2818

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

mraspaud
Copy link
Member

This PR makes sure that the same hdf5 dataset read from the same file yields the same dask array (name).

@mraspaud mraspaud added the bug label Jun 13, 2024
@mraspaud mraspaud self-assigned this Jun 13, 2024
@mraspaud mraspaud requested a review from djhoese as a code owner June 13, 2024 12:05
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (83678ac) to head (2c6af5e).
Report is 363 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2818      +/-   ##
==========================================
- Coverage   95.95%   95.94%   -0.01%     
==========================================
  Files         368      366       -2     
  Lines       53692    53518     -174     
==========================================
- Hits        51518    51346     -172     
+ Misses       2174     2172       -2     
Flag Coverage Δ
behaviourtests 4.04% <0.00%> (+0.01%) ⬆️
unittests 96.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jun 13, 2024

Pull Request Test Coverage Report for Build 9499281255

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 96.041%

Totals Coverage Status
Change from base Build 9497248893: 0.001%
Covered Lines: 51573
Relevant Lines: 53699

💛 - Coveralls

satpy/readers/hdf5_utils.py Outdated Show resolved Hide resolved
We also now use tokenize and automatic chunk sizes
@djhoese
Copy link
Member

djhoese commented Jun 19, 2024

Windows environment was failing for seemingly unrelated reasons. Restarted...

@coveralls
Copy link

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9579385362

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 17 of 17 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 96.041%

Totals Coverage Status
Change from base Build 9497248893: 0.001%
Covered Lines: 51575
Relevant Lines: 53701

💛 - Coveralls

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell this looks good to me. Feel free to merge.

@mraspaud mraspaud merged commit a7ff99f into pytroll:main Jun 19, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composite snow_age fails (no 'area') after composite cloud_phase
3 participants