Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EO-SIP AVHRR LAC data #2762

Merged
merged 7 commits into from
Mar 19, 2024

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Mar 18, 2024

This PR fixes a couple of things in the avhrr gaclac reader to accept EO-SIP (ESA) format LAC data

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Mar 18, 2024
@mraspaud mraspaud self-assigned this Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (45f918e) to head (5ffe15e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2762   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files         377      377           
  Lines       53468    53489   +21     
=======================================
+ Hits        51287    51310   +23     
+ Misses       2181     2179    -2     
Flag Coverage Δ
behaviourtests 4.10% <0.00%> (-0.01%) ⬇️
unittests 96.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Mar 18, 2024

Pull Request Test Coverage Report for Build 8348304532

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 96.005%

Totals Coverage Status
Change from base Build 8282476634: 0.006%
Covered Lines: 51182
Relevant Lines: 53312

💛 - Coveralls

@mraspaud mraspaud marked this pull request as ready for review March 18, 2024 14:51
Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The logic for finding the reader class, sensor etc could be moved to a separate method, otherwise looks good to me!

satpy/readers/avhrr_l1b_gaclac.py Outdated Show resolved Hide resolved
satpy/readers/avhrr_l1b_gaclac.py Outdated Show resolved Hide resolved
Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud mraspaud merged commit 8527311 into pytroll:main Mar 19, 2024
17 of 19 checks passed
@mraspaud mraspaud deleted the feature-eo-sip-support branch March 19, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants