Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of warnings in compositor tests #2684

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Dec 12, 2023

This PR cleans the compositor tests so that they emit zero warnings when ran with pytest -Werror satpy/tests/test_composites.py satpy/tests/compositor_tests/.

The backwards incompatile change is the removal of GreenCorrector class, which is not used internally, and was deprecated in November 2022 in v0.39.0. Someone might be using it in their own configs.

The lower version limit of XArray is raised to v0.14.1 where xr.DataArray.drop_vars() was added and .drop() was deprecated.

Three deprecated AHI composites were removed, which were related to the deprecation of GreenCorrector.

  • Tests adjusted

@pnuu pnuu added component:compositors backwards-incompatibility Causes backwards incompatibility or introduces a deprecation component:tests cleanup Code cleanup but otherwise no change in functionality labels Dec 12, 2023
@pnuu pnuu self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (338817d) 95.32% compared to head (336fc9c) 95.32%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2684   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files         371      371           
  Lines       52435    52427    -8     
=======================================
- Hits        49982    49975    -7     
+ Misses       2453     2452    -1     
Flag Coverage Δ
behaviourtests 4.16% <0.00%> (+<0.01%) ⬆️
unittests 95.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7182050794

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 95.887%

Totals Coverage Status
Change from base Build 7180375207: 0.001%
Covered Lines: 50101
Relevant Lines: 52250

💛 - Coveralls

@pnuu pnuu merged commit a78b36f into pytroll:main Dec 14, 2023
18 of 19 checks passed
@pnuu pnuu deleted the compositor-warnings branch December 14, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatibility Causes backwards incompatibility or introduces a deprecation cleanup Code cleanup but otherwise no change in functionality component:compositors component:tests
Projects
Development

Successfully merging this pull request may close these issues.

3 participants