Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fci/l2/amv/reader #2683

Merged
merged 14 commits into from
Dec 15, 2023
Merged

Fci/l2/amv/reader #2683

merged 14 commits into from
Dec 15, 2023

Conversation

YouvaEUMex
Copy link
Contributor

@YouvaEUMex YouvaEUMex commented Dec 12, 2023

This PR add a reader for the FCI L2 AMV.
Since the AMV products are NetCDF files that only use 1 dimension (number_of_winds) to define all the variables.
It need a dedicated File Handler to avoid adding exception handler for non-array stuff like x and y.
This File handler inherit FciL2CommonFunctions and only modify a couple of methods including the get_dataset.
It is rather simple and does not process the data.
There is no Area definition since the product does not contain any.
Only the lat,lon needs to be used to project and display the AMV on a map.

  • Tests added
  • Fully documented(see EUM PUG?)

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbe017c) 95.31% compared to head (be666eb) 95.35%.
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2683      +/-   ##
==========================================
+ Coverage   95.31%   95.35%   +0.03%     
==========================================
  Files         371      371              
  Lines       52435    52464      +29     
==========================================
+ Hits        49980    50028      +48     
+ Misses       2455     2436      -19     
Flag Coverage Δ
behaviourtests 4.15% <0.00%> (-0.01%) ⬇️
unittests 95.97% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Dec 12, 2023

Pull Request Test Coverage Report for Build 7210821644

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 65 of 65 (100.0%) changed or added relevant lines in 2 files are covered.
  • 49 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.04%) to 95.921%

Files with Coverage Reduction New Missed Lines %
satpy/tests/test_resample.py 2 99.57%
satpy/composites/init.py 4 93.07%
satpy/resample.py 43 88.74%
Totals Coverage Status
Change from base Build 7180375207: 0.04%
Covered Lines: 50154
Relevant Lines: 52287

💛 - Coveralls

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR, thanks for putting it up! Some comments and questions inline.

satpy/etc/readers/fci_l2_nc.yaml Show resolved Hide resolved
satpy/readers/fci_l2_nc.py Outdated Show resolved Hide resolved
satpy/readers/fci_l2_nc.py Show resolved Hide resolved
satpy/tests/reader_tests/test_fci_l2_nc.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_fci_l2_nc.py Outdated Show resolved Hide resolved
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Dec 15, 2023
@mraspaud mraspaud merged commit 56df5da into pytroll:main Dec 15, 2023
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants