Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of warnings in resampler tests #2681

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Dec 12, 2023

This PR adjusts the resamplers so that the tests do not issue any warnings.

Also warning from import gradient search is handled. This is not visible in the tests, but I've seen this in real usage.

  • Tests added

@pnuu pnuu added component:resampling component:tests cleanup Code cleanup but otherwise no change in functionality labels Dec 12, 2023
@pnuu pnuu self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (338817d) 95.32% compared to head (1bb5655) 95.32%.
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2681      +/-   ##
==========================================
- Coverage   95.32%   95.32%   -0.01%     
==========================================
  Files         371      371              
  Lines       52435    52398      -37     
==========================================
- Hits        49982    49946      -36     
+ Misses       2453     2452       -1     
Flag Coverage Δ
behaviourtests 4.16% <11.11%> (-0.01%) ⬇️
unittests 95.93% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnuu pnuu marked this pull request as ready for review December 12, 2023 11:20
@coveralls
Copy link

coveralls commented Dec 12, 2023

Pull Request Test Coverage Report for Build 7209266780

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 95.885%

Totals Coverage Status
Change from base Build 7180375207: -0.001%
Covered Lines: 50072
Relevant Lines: 52221

💛 - Coveralls

from pyresample.ewa import DaskEWAResampler, LegacyDaskEWAResampler
from pyresample.geometry import SwathDefinition
from pyresample.gradient import GradientSearchResampler
from pyresample.gradient import create_gradient_search_resampler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module docstring still uses the class. If it shouldn't, could you update it to point to this function too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this! Fixed in 1bb5655

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made one comment about the docstring. Besides that this looks good to go. Thanks!

@pnuu pnuu merged commit 4076e99 into pytroll:main Dec 14, 2023
17 of 19 checks passed
@pnuu pnuu deleted the resampler-warnings branch December 14, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup but otherwise no change in functionality component:resampling component:tests
Projects
Development

Successfully merging this pull request may close these issues.

3 participants