-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate entries of required netcdf variables in FCI reader #2634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #2634 +/- ##
==========================================
+ Coverage 95.18% 95.20% +0.02%
==========================================
Files 354 354
Lines 51316 51368 +52
==========================================
+ Hits 48846 48906 +60
+ Misses 2470 2462 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
There could be some others that are read twice even if not listed, like |
Yep, all the separately listed attributes of |
Pull Request Test Coverage Report for Build 6822460998
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, well spotted!
While testing things to speed-up FCI reader, I noticed there were some duplicate/triplicate entries in the FCI reader YAML listing the required netcdf variables. Each of these in themselves caused extra file access, so this also speeds up the reader a tiny bit.