-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance code quality #6
Enhance code quality #6
Commits on May 29, 2024
-
- Fix typos. - Fix broken links. - Improve readability.
Configuration menu - View commit details
-
Copy full SHA for c45a504 - Browse repository at this point
Copy the full SHA c45a504View commit details -
Filter undesirable special members from autodoc.
Update conf.py with functionalities to specify which special members have to be kept in the documentation.
Configuration menu - View commit details
-
Copy full SHA for 2a5f8a1 - Browse repository at this point
Copy the full SHA 2a5f8a1View commit details -
The name of the `pipelines` module was mistakenly spelled as `piplines`.
Configuration menu - View commit details
-
Copy full SHA for abc8a32 - Browse repository at this point
Copy the full SHA abc8a32View commit details -
Replace the term
mock
withtest
There were several places that we had used `mock data` to refer to data generated for testing purposes. This was misleading as we are actually generating the data and the API calls are not mocked. Example `mock_database` is renamed to `test_database`.
Configuration menu - View commit details
-
Copy full SHA for 603b02f - Browse repository at this point
Copy the full SHA 603b02fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55915f9 - Browse repository at this point
Copy the full SHA 55915f9View commit details -
Add more tests for the
queries
routeAs a result, `test_utils` and the `queries` route handler have been also updated.
Configuration menu - View commit details
-
Copy full SHA for 9ee2e60 - Browse repository at this point
Copy the full SHA 9ee2e60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 409df77 - Browse repository at this point
Copy the full SHA 409df77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76fe40e - Browse repository at this point
Copy the full SHA 76fe40eView commit details -
Update API to use new query annotations
The new version of FastAPI recommends using `Annotated` for queries. This also resolves the issue with ruff complaining about `Query(None)`.
Configuration menu - View commit details
-
Copy full SHA for c00a7a6 - Browse repository at this point
Copy the full SHA c00a7a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4298f5 - Browse repository at this point
Copy the full SHA a4298f5View commit details
Commits on May 30, 2024
-
Improve type checks and validation using Pydantic
This led to the removal of some redundant type checks.
Configuration menu - View commit details
-
Copy full SHA for f0c7e16 - Browse repository at this point
Copy the full SHA f0c7e16View commit details -
Fix a bug and add a log message
The bug had to do with multiple deletion in the recorder. The log message was added to the auto exception handler.
Configuration menu - View commit details
-
Copy full SHA for 825bff7 - Browse repository at this point
Copy the full SHA 825bff7View commit details -
Simplify
test_utils.TestDatabase.match_query()
Add two auxiliary methods which simplify the implementation of the main method.
Configuration menu - View commit details
-
Copy full SHA for 5ab9e27 - Browse repository at this point
Copy the full SHA 5ab9e27View commit details -
Extract a function to make a single query string in
test_api
The function is named `make_query_string`
Configuration menu - View commit details
-
Copy full SHA for fb78e7c - Browse repository at this point
Copy the full SHA fb78e7cView commit details -
Change the signature of
parse_config
The old name of the function was `parse_config_yaml_file`. The function now accepts a number of different types for the input arg `file`.
Configuration menu - View commit details
-
Copy full SHA for 91aebe2 - Browse repository at this point
Copy the full SHA 91aebe2View commit details -
Add
@logger.catch
to therun_server
functionThis logs and catches unhandled exceptions.
Configuration menu - View commit details
-
Copy full SHA for 598b09f - Browse repository at this point
Copy the full SHA 598b09fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95f9de6 - Browse repository at this point
Copy the full SHA 95f9de6View commit details
Commits on May 31, 2024
-
- Remove type hint for `file`. - Amend docstring. - Remove explicit exception handling for parsing and reading the file.
Configuration menu - View commit details
-
Copy full SHA for 89ccff0 - Browse repository at this point
Copy the full SHA 89ccff0View commit details -
Remove type checks for config in
api.py
As a result, the signature of `run_server()` and `api_server_process_context()` have been changed. They now only accept a `config` object of type `AppConfig`.
Configuration menu - View commit details
-
Copy full SHA for 506f122 - Browse repository at this point
Copy the full SHA 506f122View commit details -
Reorder functions in test scripts.
The dependencies are now brought after the first main dependent function that uses them.
Configuration menu - View commit details
-
Copy full SHA for c42f8cc - Browse repository at this point
Copy the full SHA c42f8ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 781891d - Browse repository at this point
Copy the full SHA 781891dView commit details