Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AMI channel aliases from Satpy #84

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Add AMI channel aliases from Satpy #84

merged 1 commit into from
Oct 3, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Oct 3, 2019

Satpy uses channel names (reader is not yet merged) from the AMI filenames and file content. These are not simple channel numbers but things like VI008. This PR adds aliases for these AMI channel names to pyspectral's standard ch1 names.

@djhoese djhoese added the bug label Oct 3, 2019
@djhoese djhoese requested a review from adybbroe October 3, 2019 17:32
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 73.0% when pulling 3e8bc16 on djhoese:bugfix-ami-channel-aliases into ce48060 on pytroll:master.

adybbroe
adybbroe approved these changes Oct 3, 2019
View reviewed changes
Copy link
Collaborator

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adybbroe adybbroe merged commit 6f7f569 into pytroll:master Oct 3, 2019
@djhoese djhoese deleted the bugfix-ami-channel-aliases branch October 3, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adybbroe adybbroe adybbroe approved these changes

Assignees

@adybbroe adybbroe

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djhoese @coveralls @adybbroe