Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FY-3B VIRR and FY-3C VIRR RSRs #78

Merged
merged 6 commits into from
Aug 30, 2019
Merged

Add FY-3B VIRR and FY-3C VIRR RSRs #78

merged 6 commits into from
Aug 30, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Aug 28, 2019 •
edited by adybbroe
Loading

Needed for making rayleigh corrected true colors. This is still a WIP because rayleigh correction in satpy is producing an orange image for some reason.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff
  • Fully documented

@djhoese djhoese requested a review from adybbroe August 28, 2019 20:32
@adybbroe
Copy link
Collaborator

Looks good @djhoese Thanks!
Can you update the version number in utils.py and the zenodo url to point to the latest upload. I added your VIRR files and uploaded a new version. Then it is ready to merge

adybbroe
adybbroe requested changes Aug 29, 2019
View reviewed changes
Copy link
Collaborator

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, as said, looks fine! But fix the version and the zenodo link to the newly updated data, and fix the merge conflicts. Tell me if I can do something!

@djhoese djhoese changed the title [WIP] Add FY-3B VIRR and FY-3C VIRR RSRs Add FY-3B VIRR and FY-3C VIRR RSRs Aug 29, 2019
@djhoese
Copy link
Member Author

djhoese commented Aug 29, 2019

Latest commit fixes the MODIS/AVHRR channel mapping and cleans up a couple tests. Two of the tests fail on my local OSX machine, but if they pass on the CIs then I'll let it be.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 72.988% when pulling 0b85f7f on djhoese:feature-virr into 3bbedb2 on pytroll:master.

@adybbroe adybbroe self-assigned this Aug 30, 2019
@adybbroe adybbroe merged commit f42aae8 into pytroll:master Aug 30, 2019
@djhoese djhoese deleted the feature-virr branch August 30, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adybbroe adybbroe adybbroe requested changes

Assignees

@adybbroe adybbroe

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djhoese @adybbroe @coveralls