Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support and RSR converter for the GOCI2 instrument aboard GK-2B #224

Merged
merged 3 commits into from
May 3, 2024

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented May 3, 2024

This PR adds a script to generate the spectral response function data for the GOCI-2 instrument aboard GeoKompsat-2B.
The RSR raw data has been taken from the official website and the generated data file for pyspectral is available here:
rsr_goci2_GK-2B.zip.

I have also edited a string in the YAML file to make it less clear that it was me who added EPIC support ;-)

  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.00%. Comparing base (677af34) to head (b1c040a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files          23       23           
  Lines        2571     2571           
=======================================
  Hits         2314     2314           
  Misses        257      257           
Flag Coverage Δ
unittests 90.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonrp84 simonrp84 requested review from adybbroe and djhoese May 3, 2024 07:06
@simonrp84
Copy link
Member Author

The 3.12 unstable tests are failing, but that looks like it's to do with numpy 2 rather than anything to do with this PR.

@adybbroe adybbroe self-assigned this May 3, 2024
Copy link
Collaborator

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though I fail fetching the original SRFs?

@simonrp84
Copy link
Member Author

LGTM. Though I fail fetching the original SRFs?

I've now also added a direct link to the SRFs in addition to the (more stable) link to the website that hosts the SRFs.

@adybbroe adybbroe merged commit 3157e71 into pytroll:main May 3, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants