Fix rayleigh not preserving input dtype #195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed briefly on slack, but I noticed that the rayleigh correction in Satpy causes 32-bit float inputs to become 64-bit float outputs after correction. This is mostly due to two things:
dtype
argument that wasn't being specified and defaults to float64.This PR fixes both and includes an update to the pre-commit config. I also added pyspectral to pre-commit.ci so the pre-commit config should be automatically updated for us.
NOTE: This PR doesn't make a huge difference in performance, but it doesn't hurt either. I think the consistency alone is worth it.
pytest pyspectral
flake8 pyspectral