Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove author names from headers and tidy up for flake8 issues #163

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

adybbroe
Copy link
Collaborator

@adybbroe adybbroe commented Oct 19, 2022

This PR removes the author names from headers.
Now also urge contributors to add their name in the AUTHORS.md

While doing this I fixed many small code style issues upseting flake8.

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral
  • Fully documented

@adybbroe adybbroe self-assigned this Oct 19, 2022
@adybbroe adybbroe requested a review from djhoese October 19, 2022 19:21
@adybbroe
Copy link
Collaborator Author

@Plantain Perhaps you want to add your name to the AUTHORS.md file, you are welcome doing it here at least!

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #163 (45e3bfe) into main (d36a108) will decrease coverage by 0.05%.
The diff coverage is 93.93%.

@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
- Coverage   89.08%   89.03%   -0.06%     
==========================================
  Files          22       22              
  Lines        2529     2516      -13     
==========================================
- Hits         2253     2240      -13     
  Misses        276      276              
Flag Coverage Δ
unittests 89.03% <93.93%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyspectral/atm_correction_ir.py 81.35% <ø> (ø)
pyspectral/bandnames.py 100.00% <ø> (ø)
pyspectral/raw_reader.py 0.00% <0.00%> (ø)
pyspectral/tests/data.py 100.00% <ø> (ø)
pyspectral/tests/test_utils.py 98.00% <ø> (ø)
pyspectral/tests/unittest_helpers.py 71.42% <ø> (ø)
pyspectral/blackbody.py 79.46% <100.00%> (ø)
pyspectral/config.py 80.48% <100.00%> (ø)
pyspectral/near_infrared_reflectance.py 80.53% <100.00%> (-0.13%) ⬇️
pyspectral/radiance_tb_conversion.py 92.85% <100.00%> (-0.25%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion for Helge's name

AUTHORS.md Outdated Show resolved Hide resolved
Co-authored-by: Martin Raspaud <[email protected]>
@adybbroe adybbroe merged commit 0531238 into pytroll:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants