-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RSR band name retrieval for unconfigured sensors #158
Conversation
Codecov Report
@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 88.00% 88.02% +0.01%
==========================================
Files 22 22
Lines 2468 2472 +4
==========================================
+ Hits 2172 2176 +4
Misses 296 296
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I manually checked the HDF5 file and it seems like it is using the
|
@djhoese |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes, from Satpy. I don't think changing that logger is a good long term idea. I did actually add Thanks for reviewing. |
This adds the missing configuration for mapping MERSI-2 band names to the names used in the RSR files. It is basically "ruined" by the generic mapping mapping numeric band names toch{:d}
. This isn't the case for MERSI-2 which uses the same band name.It turns out MERSI-2 does use the
chN
names in the RSR HDF5 files, but since it wasn't configured anif
statement in the RSR Reader was failing with a KeyError before it was supposed to. This PR should fix this so that the "generic" band names are used as a fallback.pytest pyspectral
flake8 pyspectral