Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix noaa6 rsr #157

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Fix noaa6 rsr #157

merged 3 commits into from
Oct 5, 2022

Conversation

adybbroe
Copy link
Collaborator

@adybbroe adybbroe commented Sep 27, 2022

This PR fixes errors recently discovered in the NOAA-6 AVHRR RSR data, see #155
It also adds a changelog for the RSR data on Zenodo, and updates to point at the latest upload there, including VIIRS RSR data for NOAA-21. See #156

Adam.Dybbroe added 3 commits September 26, 2022 19:35
Signed-off-by: Adam.Dybbroe <[email protected]>
…SR data on zenodo and update url

Signed-off-by: Adam.Dybbroe <[email protected]>
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #157 (d096074) into main (e2744cd) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   87.94%   88.00%   +0.05%     
==========================================
  Files          23       22       -1     
  Lines        2473     2467       -6     
==========================================
- Hits         2175     2171       -4     
+ Misses        298      296       -2     
Flag Coverage Δ
unittests 88.00% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyspectral/utils.py 79.35% <100.00%> (ø)
pyspectral/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adybbroe
Copy link
Collaborator Author

In addition to fixing NOAA-6 I had to change one wavelength from 640nm to 840nm, as it clearly looked like a typo:
rsr_band_0040_0090_tirosn_original_xls_file
rsr_band_0040_0090_tirosn_corrected_xls_file

Copy link
Member

@simonrp84 simonrp84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NOAA-6 spectral responses are wrong for channel 1 & 2
3 participants