-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more realistic METimage RSRs #109
add more realistic METimage RSRs #109
Conversation
…tions for METimage
The new file looks good and i tested reading with hdfview and a pyspectral plotting routine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rolle-at-work I think you could/should use the todf5
function in utils.py
. Then we will also get rid of the redundant det-1
layer. There is only one detector, and in that case I think we should not use that extra layer
@adybbroe But is this layer also gone for AVHRR and other one-detector instruments? I think this layer was usefull to allow for a general reader of bof both single and multi detector instruments. |
Yes @rolle-at-work they are gone for all single detector sensors. They should be at least. I just checked a couple. And the reader can handle both, no problem |
Oh well, now I look back in the history here: |
Yes @adybbroe METimage will have 24 detectors per channel |
@rolle-at-work I have uploaded an updated RSR data archive with your new Metimage data included, please check it out and adapt your PR accordingly. You will need to change version and url of the RSR data in |
…tions for METimage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, @rolle-at-work, could you please update utils.py
according to my comments
…-at-work/pyspectral into add_simulated_metimage_rsr looks like i have to do this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updated to more realistic, though not measured spectral response functions for METimage
pytest pyspectral
flake8 pyspectral