Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move setuptools to setup_requires #624

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

avalentino
Copy link
Contributor

Apparently setuptools is not required at runtime

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Fully documented

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.98%. Comparing base (c4ce8ee) to head (85840cf).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
+ Coverage   93.97%   93.98%   +0.01%     
==========================================
  Files          86       86              
  Lines       13848    13848              
==========================================
+ Hits        13013    13015       +2     
+ Misses        835      833       -2     
Flag Coverage Δ
unittests 93.98% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was pretty sure we used setuptools somewhere inside pyresample, but it looks like that is all done through importlib now so I think this is fine.

@djhoese djhoese added bug dependencies Pull requests that update a dependency file labels Oct 7, 2024
@djhoese djhoese self-assigned this Oct 7, 2024
@djhoese
Copy link
Member

djhoese commented Oct 7, 2024

...and I should have said: thanks.

@coveralls
Copy link

Coverage Status

coverage: 93.686%. remained the same
when pulling 85840cf on avalentino:bugfix/setup_requires
into 9becb0d on pytroll:main.

@djhoese djhoese merged commit 753227c into pytroll:main Oct 7, 2024
26 checks passed
@avalentino avalentino deleted the bugfix/setup_requires branch October 8, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants