Fix DDP with gradient_as_bucket_view enabled #8521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaochengji
requested review from
mikegre-google and
tengyifei
as code owners
tengyifei
approved these changes
Jan 3, 2025
|
Thanks! |
tengyifei
pushed a commit
that referenced
this pull request
Jan 14, 2025
This was referenced Jan 14, 2025
ManfeiBai
pushed a commit
that referenced
this pull request
Jan 14, 2025
Co-authored-by: Chengji Yao <[email protected]>
qihqi
pushed a commit
that referenced
this pull request
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.