Disable the Sandbox build in Docker #4515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManfeiBai
pushed a commit
that referenced
this pull request
Jan 30, 2023
will-cromar
added a commit
that referenced
this pull request
Feb 16, 2023
This reverts commit 661ab6d.
stgpetrovic
added a commit
that referenced
this pull request
Feb 17, 2023
* Revert "Disable the Sandbox build in Docker (#4515)" This reverts commit 661ab6d. * Remove submodule step from TPU CI * Update cloudbuild.yaml * Remove separate TF build step * Add bazel WORKSPACE and rc * Update Dockerfile * throw more compute at the TPU CI build * more bazel jobs * Revert to old machine type and default to local builds. * Revert to default nonsandbox * Remove jobs limitation * Try smaller shm * Fix build of llvm in sandbox * Mount 7g of ram properly * TEMP remove pytorch build * remove install of packages * confirm shm creation * Revert machine type --------- Co-authored-by: Will Cromar <[email protected]> Co-authored-by: Will Cromar <[email protected]>
mateuszlewko
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Revert "Disable the Sandbox build in Docker (#4515)" This reverts commit 661ab6d. * Remove submodule step from TPU CI * Update cloudbuild.yaml * Remove separate TF build step * Add bazel WORKSPACE and rc * Update Dockerfile * throw more compute at the TPU CI build * more bazel jobs * Revert to old machine type and default to local builds. * Revert to default nonsandbox * Remove jobs limitation * Try smaller shm * Fix build of llvm in sandbox * Mount 7g of ram properly * TEMP remove pytorch build * remove install of packages * confirm shm creation * Revert machine type --------- Co-authored-by: Will Cromar <[email protected]> Co-authored-by: Will Cromar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will kick off a docker build on this branch to veirfy sandbox can be removed. I already tried that in my TPUVM.