nms_cuda signature update #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated nms_cuda signature to accept detections and scores as separate tensors. This also required updating the indexing in the NMS CUDA kernel. Also made the iou_threshold parameter name consistent across implementations.
Codecov Report
@@ Coverage Diff @@
## master #945 +/- ##
==========================================
+ Coverage 60.13% 60.15% +0.01%
==========================================
Files 63 63
Lines 5019 5019
Branches 748 748
==========================================
+ Hits 3018 3019 +1
+ Misses 1797 1796 -1
Partials 204 204
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
nms_cudasignature to accept detections and scores as separate tensors. This makes the function signature consistent as well as avoids making temporary tensors and wasting memory as a result.This required updating the indexing in the NMS CUDA kernel.
Also made the
iou_thresholdparameter name consistent across implementations.