Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement of the STL10 loader #914

Merged
merged 2 commits into from
May 29, 2019

Conversation

edouardoyallon
Copy link
Contributor

Closes #167

This PR adds the possibility to use the standard procedure for evaluating a model on STL-10. It simply loads one of the 10 pre-defined folds included in the original tar-file and retains the corresponding data from the training set.

It should be consistent with the previous dataloader, as if no fold is specified, it possibly loads the whole training set (and then leads to an erroneous validation error)

@codecov-io
Copy link

codecov-io commented May 19, 2019

Codecov Report

Merging #914 into master will decrease coverage by 0.06%.
The diff coverage is 21.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
- Coverage    57.9%   57.83%   -0.07%     
==========================================
  Files          46       46              
  Lines        3696     3709      +13     
  Branches      561      563       +2     
==========================================
+ Hits         2140     2145       +5     
- Misses       1429     1439      +10     
+ Partials      127      125       -2
Impacted Files Coverage Δ
torchvision/datasets/stl10.py 27.5% <21.42%> (-2.36%) ⬇️
torchvision/datasets/imagenet.py 21.55% <0%> (ø) ⬆️
torchvision/transforms/transforms.py 82.54% <0%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b384c4e...8231a9a. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 579eebe into pytorch:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STL-10 Testing Protocol
3 participants