Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added resized_crop_segmentation_mask op #5855

Merged
merged 15 commits into from
Apr 25, 2022

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Apr 21, 2022

Related to #5514

Description:

  • Added functional resized_crop_segmentation_mask op
  • Added a basic correctness test

Results on synthetic images/bboxes/segm mask:

image

@vfdev-5 vfdev-5 marked this pull request as ready for review April 25, 2022 09:58
@datumbox datumbox requested a review from pmeier April 25, 2022 09:59
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pmeier any thoughts on the testing side?

@pmeier
Copy link
Collaborator

pmeier commented Apr 25, 2022

Nope. I'm currently refactoring the functional tests to be more structured. I'll port these test when I send my PR.

@vfdev-5 vfdev-5 merged commit de31e4b into pytorch:main Apr 25, 2022
@vfdev-5 vfdev-5 deleted the proto-mask-resized-crop branch April 25, 2022 15:28
@github-actions
Copy link

Hey @vfdev-5!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request May 6, 2022
Summary:
* [proto] Added crop_bounding_box op

* Added `crop_segmentation_mask` op

* Fixed failed mypy

* Added tests for resized_crop_bounding_box

* Fixed code formatting

* Added resized_crop_segmentation_mask op

* Added tests

Reviewed By: jdsgomes, NicolasHug

Differential Revision: D36095695

fbshipit-source-id: 808c8c2216084999a3baa6f65d49287039f3cf84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants