-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proto] Added functional rotate_segmentation_mask
op
#5692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a cude/cpu test Reduced the number of test samples
💊 CI failures summary and remediationsAs of commit e0f7663 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
vfdev-5
commented
Mar 28, 2022
pmeier
reviewed
Mar 28, 2022
datumbox
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
Summary: * Added functional affine_bounding_box op with tests * Updated comments and added another test case * Update _geometry.py * Added affine_segmentation_mask with tests * Fixed device mismatch issue Added a cude/cpu test Reduced the number of test samples * Added test_correctness_affine_segmentation_mask_on_fixed_input * Updates according to the review * Replaced [None, ...] by [None, :] * Adressed review comments * Fixed formatting and more updates according to the review * Fixed bad merge * WIP * Fixed tests * Updated warning message Reviewed By: NicolasHug Differential Revision: D35393159 fbshipit-source-id: e6950844f1e0066f879019a72001a673f501281e
This was referenced Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5514
Description:
rotate_segmentation_mask
opResults on synthetic images/bboxes/segm mask:
Code