Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bbox scaling estimation for Large Scale Jitter #5446

Merged
merged 2 commits into from
Feb 20, 2022

Conversation

datumbox
Copy link
Contributor

Fixing the bbox scaling miscalculation for when the the target_size is not proportional to the original image.

@facebook-github-bot
Copy link

facebook-github-bot commented Feb 20, 2022

💊 CI failures summary and remediations

As of commit 59abc90 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox datumbox mentioned this pull request Feb 20, 2022
24 tasks
@datumbox datumbox requested a review from fmassa February 20, 2022 10:21
@datumbox
Copy link
Contributor Author

datumbox commented Feb 20, 2022

Merging fix to be able to continue the training, the patch is tested on the reference scripts and it works.

@datumbox datumbox merged commit 034c222 into pytorch:main Feb 20, 2022
@datumbox datumbox deleted the bugfix/lsj_box_scaling branch February 20, 2022 10:22
@github-actions
Copy link

Hey @datumbox!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Feb 25, 2022
Summary:
* Fix bbox scaling estimation for Large Scale Jitter

* Fix linter

Reviewed By: jdsgomes

Differential Revision: D34475306

fbshipit-source-id: 717e7b09d5b2b01758711799ae1ef1bcb1f75050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants