Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade tqdm version to 4.19 for py2.7 #542

Merged
merged 4 commits into from
Jul 13, 2018
Merged

Downgrade tqdm version to 4.19 for py2.7 #542

merged 4 commits into from
Jul 13, 2018

Conversation

vishwakftw
Copy link
Contributor

This was observed during discussion in #541 . This will prevent spurious error while downloading.

cc @fmassa

@fmassa
Copy link
Member

fmassa commented Jul 10, 2018

Do we know what's the reason why we have the error message with newer versions of tqdm? It might be better to find out the reason and address it properly?

@vishwakftw
Copy link
Contributor Author

This is an unsolved bug in tqdm. tqdm/tqdm#548 .

@vishwakftw
Copy link
Contributor Author

@fmassa is this good to go?

@fmassa fmassa merged commit cd1f58f into pytorch:master Jul 13, 2018
@fmassa
Copy link
Member

fmassa commented Jul 13, 2018

Thanks!

@vishwakftw vishwakftw deleted the tqdm-version-fix branch July 13, 2018 17:25
varunagrawal pushed a commit to varunagrawal/vision that referenced this pull request Jul 23, 2018
* reduce tqdm version to 4.19 for py2.7 to avoid spurious error

* Update setup.py

* Missed =

* Update wrong version string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants