make vision depend on pillow-simd if already installed #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
approved these changes
May 30, 2018
|
this is awesome! |
facebook-github-bot
pushed a commit
to fossasia/visdom
that referenced
this pull request
Jun 7, 2018
Summary: As discussed in #367, this PR allows visdom to work with Pillow-simd if the end user has it installed. What this PR does, is that upon installation it checks if pillow-simd is installed and adds it to the requirements if it is. Otherwise, regular pillow is added. Pillow-simd is a drop-in replacement that uses the same namespace, so no further changes are required. __Disclaimer:__ I did not figure this one out on my own, but saw this solution in [pytorch/vision](pytorch/vision#522). This solution might have some problems I am not aware of, as I am no guru when working with setuptools. One thing I do know, is that this will cause a problem when creating pip wheels, so that should be taken into consideration. _(I dont think that this is a concern for this project)_ Closes #368 Differential Revision: D8314365 Pulled By: JackUrb fbshipit-source-id: 9cc52eee5ad129263136a7d6c6cfa86e288e89eb
varunagrawal
pushed a commit
to varunagrawal/vision
that referenced
this pull request
Jul 23, 2018
* make vision depend on pillow-simd if already installed * actually make pillow-simd optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.