Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize and pil link fix #519

Merged
merged 2 commits into from
May 26, 2018
Merged

Normalize and pil link fix #519

merged 2 commits into from
May 26, 2018

Conversation

kohr-h
Copy link
Contributor

@kohr-h kohr-h commented May 26, 2018

Update for a broken link to the PIL docs, and a more efficient version of the normalize transform.

@soumith soumith merged commit b1ef1fe into pytorch:master May 26, 2018
@soumith
Copy link
Member

soumith commented May 26, 2018

thank you!

@vfdev-5
Copy link
Collaborator

vfdev-5 commented May 26, 2018

@kohr-h looks good, as you are on F.normalize, maybe it would be nice to add a notice in the documentation to cover #517 ?
cc @soumith

@kohr-h
Copy link
Contributor Author

kohr-h commented May 26, 2018

@vfdev-5 What would be the intention here, efficiency or keeping input intact? Looking at other transforms, they never explicitly copy, but probably most of them can't work in-place anyway.

I can add a notice in the docs, sure.

@kohr-h kohr-h deleted the normalize_and_pil_link_fix branch May 26, 2018 15:39
@vfdev-5
Copy link
Collaborator

vfdev-5 commented May 26, 2018

@kohr-h I would say that efficiency is better and among all other transforms F.normalize is the only transform working on torch.Tensor and returning torch.Tensor, so just add a notice that it works in-place can be enough IMO

varunagrawal pushed a commit to varunagrawal/vision that referenced this pull request Jul 23, 2018
* Fix PIL link

* Make normalize more efficient
varunagrawal pushed a commit to varunagrawal/vision that referenced this pull request Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants