Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Bar for download_url #497

Merged
merged 5 commits into from
May 11, 2018
Merged

Progress Bar for download_url #497

merged 5 commits into from
May 11, 2018

Conversation

maruthgoyal
Copy link
Contributor

The progress bar updates by the count of blocks being transferred, and by default displayed elapsed time, ETA, number of blocks/total blocks, and the percentage. I've used the progressbar2 library, found here: https://github.com/WoLpH/python-progressbar; it's licensed under BSD 3-clause.

@soumith
Copy link
Member

soumith commented May 11, 2018

can you please switch to tqdm for the progress bar. It's the most standard and really good. https://github.com/tqdm/tqdm

The required changes should be minor

@maruthgoyal
Copy link
Contributor Author

Sure thing! Should be updated now!

@soumith soumith merged commit 47214f0 into pytorch:master May 11, 2018
@soumith
Copy link
Member

soumith commented May 11, 2018

thanks!

varunagrawal pushed a commit to varunagrawal/vision that referenced this pull request Jul 23, 2018
* Added Progress Bar to the dataset downloading utility

* Updated progressbar to update by blcoks

* Added progressbar2 to the requirements

* fixed style issues

* Shifted from progressbar to tqdm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants