Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enumerate to get index of ModuleList #4534

Merged
merged 5 commits into from
Oct 5, 2021
Merged

Conversation

fullyz
Copy link
Contributor

@fullyz fullyz commented Oct 4, 2021

Tiny tweak.

torchscript doesn't support torch.nn.ModuleList indexing but does support enumeration.

cc @datumbox

@facebook-github-bot
Copy link

Hi @fullyz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fullyz , this sounds good, provided that the tests are green.

I'll merge after the CI is finished (and after #4384!)

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@fullyz fullyz requested a review from NicolasHug October 4, 2021 16:21
@NicolasHug
Copy link
Member

NicolasHug commented Oct 4, 2021

test failure was reported on #4506

Thanks @fullyz , LGTM. I'll merge when the CLA check has finished... probably after the major fb outage is resolved :s

@NicolasHug NicolasHug merged commit 4d711fd into pytorch:main Oct 5, 2021
facebook-github-bot pushed a commit that referenced this pull request Oct 8, 2021
Summary: Co-authored-by: Nicolas Hug <[email protected]>

Reviewed By: NicolasHug

Differential Revision: D31505569

fbshipit-source-id: 78967c474a3818a8dc5fe259e9b9e7773d91d45e
mszhanyi pushed a commit to mszhanyi/vision that referenced this pull request Oct 19, 2021
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants