Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dependency table #4308

Merged
merged 1 commit into from
Aug 23, 2021
Merged

fix dependency table #4308

merged 1 commit into from
Aug 23, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Aug 23, 2021

#4306 broke the dependency table in our README. This fixes that and adds some more constraints that weren't being tracked properly.

NicolasHug
NicolasHug approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip, LGTM

I'm wondering what the reason is for specifying upper bounds on the Python version: aren't all 3.X versions backward-compatible anyway?

@pmeier
Copy link
Collaborator Author

pmeier commented Aug 23, 2021 •
edited
Loading

We only build binaries for the versions I've given in the table. So if you are on Python 3.9, you cannot pip install anything before torchvision<0.8.2. Have a look at the complete list of wheels that we provide.

@pmeier pmeier merged commit b72129c into main Aug 23, 2021
@pmeier pmeier deleted the dependency-table branch August 23, 2021 17:12
facebook-github-bot pushed a commit that referenced this pull request Aug 26, 2021
@datumbox @facebook-github-bot
[fbsync] fix dependency table (#4308)
ef2abc7 
Reviewed By: fmassa

Differential Revision: D30525889

fbshipit-source-id: 241bb5d2cc6dc82c395ef2b3d8956049db849baa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed module: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @NicolasHug @facebook-github-bot