Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for Coco(Captions|Detection) #3416

Merged
merged 3 commits into from
Feb 22, 2021
Merged

add tests for Coco(Captions|Detection) #3416

merged 3 commits into from
Feb 22, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 18, 2021

No description provided.

This was referenced Feb 18, 2021
Merged
Closed
@codecov
Copy link

codecov bot commented Feb 18, 2021 •
edited
Loading

Codecov Report

Merging #3416 (a3cf806) into master (2f4efd3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3416   +/-   ##
=======================================
  Coverage   75.13%   75.13%           
=======================================
  Files         105      105           
  Lines        9722     9722           
  Branches     1563     1563           
=======================================
  Hits         7305     7305           
  Misses       1930     1930           
  Partials      487      487

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4efd3...fba2070. Read the comment docs.

NicolasHug
NicolasHug approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier , this looks good. You might want to wait for another round from @fmassa as I might have missed some stuff ;)

@pmeier pmeier requested a review from fmassa February 19, 2021 14:33
fmassa
fmassa approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fmassa
Copy link
Member

fmassa commented Feb 22, 2021

There seems to be conflicts now , could you look into fixing them?

@fmassa fmassa merged commit a6f3f95 into pytorch:master Feb 22, 2021
facebook-github-bot pushed a commit that referenced this pull request Feb 23, 2021
@fmassa @facebook-github-bot
add tests for Coco (#3416)
a3107fa 
Summary: Co-authored-by: Francisco Massa <[email protected]>

Reviewed By: NicolasHug

Differential Revision: D26605326

fbshipit-source-id: df7d6e8c4a50d43b432906f643c55345e0d85915
@pmeier pmeier deleted the test-coco branch February 25, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmeier @fmassa @NicolasHug @facebook-github-bot